Skip to content

Commit

Permalink
fixed eslint error
Browse files Browse the repository at this point in the history
  • Loading branch information
@danney-chun
danney-chun committed Oct 7, 2024
1 parent e180c2f commit 9c47179
Show file tree
Hide file tree
Showing 11 changed files with 89 additions and 98 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/deploy-github-pages.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ jobs:

- name: Build
run: yarn build
env:
CI: false # ESLint 에러 무시

- name: List build directory
run: ls -R build
Expand Down
1 change: 0 additions & 1 deletion src/App.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ import GroupChannelReactChannelTypes from './samples/GroupChannelTypes';
import GroupChannelUpdateDeleteMessageByOperator from './samples/GroupChannelUpdateDeleteMessageByOperator';
import GroupChannelArchive from './samples/GroupChannelArchive'
import GroupChannelMuteUnmuteUsers from './samples/GroupChannelMuteUnmuteUsers';
import GroupChannelBanUnbanUsers from './samples/GroupChannelBanUnbanUsers';
import GroupChannelRetrieveNumberOfMembersHaventReceivedMessage from './samples/GroupChannelRetrieveNumberOfMembersHaventReceivedMessage';
import GroupChannelOperatorsList from './samples/GroupChannelOperatorsList';
import GroupChannelMembersListOrder from './samples/GroupChannelMembersListOrder';
Expand Down
18 changes: 9 additions & 9 deletions src/samples/BasicGroupChannelSample.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ const BasicGroupChannelSample = (props) => {
}

const handleCreateChannel = async (channelName = "testChannel",) => {
const [groupChannel, error] = await createChannel(channelName, state.groupChannelMembers);
const [error] = await createChannel(channelName, state.groupChannelMembers);
if (error) {
return onError(error);
}
Expand All @@ -172,7 +172,7 @@ const BasicGroupChannelSample = (props) => {
}

const handleDeleteChannel = async (channelUrl) => {
const [channel, error] = await deleteChannel(channelUrl);
const [error] = await deleteChannel(channelUrl);
if (error) {
return onError(error);
}
Expand Down Expand Up @@ -207,7 +207,7 @@ const BasicGroupChannelSample = (props) => {
const userMessageUpdateParams = {};
userMessageUpdateParams.message = state.messageInputValue
const updatedMessage = await currentlyJoinedChannel.updateUserMessage(messageToUpdate.messageId, userMessageUpdateParams)
const messageIndex = messages.findIndex((item => item.messageId == messageToUpdate.messageId));
const messageIndex = messages.findIndex((item => item.messageId === messageToUpdate.messageId));
messages[messageIndex] = updatedMessage;
updateState({ ...state, messages: messages, messageInputValue: "", messageToUpdate: null });
} else {
Expand All @@ -227,7 +227,7 @@ const BasicGroupChannelSample = (props) => {

const onFileInputChange = async (e) => {
if (e.currentTarget.files && e.currentTarget.files.length > 0) {
const { currentlyJoinedChannel, messages } = state;
const { currentlyJoinedChannel } = state;
const fileMessageParams = {};
fileMessageParams.file = e.currentTarget.files[0];
currentlyJoinedChannel.sendFileMessage(fileMessageParams)
Expand Down Expand Up @@ -377,7 +377,7 @@ const ChannelList = ({
</div>
<div>
<button className="control-button" onClick={() => handleDeleteChannel(channel.url)}>
<img className="channel-icon" src='/icon_delete.png' />
<img className="channel-icon" src='/icon_delete.png' alt=''/>
</button>
</div>
</div>
Expand Down Expand Up @@ -455,7 +455,7 @@ const Message = ({ message, updateMessage, handleDeleteMessage, messageSentByYou
<div className="message-sender-name">{message.sender.nickname}{' '}</div>
<div>{timestampToTime(message.createdAt)}</div>
</div>
<img src={message.url} />
<img src={message.url} alt=''/>
</div >);
}
const messageSentByCurrentUser = message.sender.userId === sb.currentUser.userId;
Expand All @@ -469,8 +469,8 @@ const Message = ({ message, updateMessage, handleDeleteMessage, messageSentByYou
</div>
{messageSentByCurrentUser &&
<div>
<button className="control-button" onClick={() => updateMessage(message)}><img className="message-icon" src='/icon_edit.png' /></button>
<button className="control-button" onClick={() => handleDeleteMessage(message)}><img className="message-icon" src='/icon_delete.png' /></button>
<button className="control-button" onClick={() => updateMessage(message)}><img className="message-icon" src='/icon_edit.png' alt=''/></button>
<button className="control-button" onClick={() => handleDeleteMessage(message)}><img className="message-icon" src='/icon_delete.png' alt=''/></button>
</div>}
</div>
<div>{message.message}</div>
Expand All @@ -480,7 +480,7 @@ const Message = ({ message, updateMessage, handleDeleteMessage, messageSentByYou

const ProfileImage = ({ user }) => {
if (user.plainProfileUrl) {
return <img className="profile-image" src={user.plainProfileUrl} />
return <img className="profile-image" src={user.plainProfileUrl} alt=''/>
} else {
return <div className="profile-image-fallback">{user.nickname.charAt(0)}</div>;
}
Expand Down
18 changes: 9 additions & 9 deletions src/samples/BasicOpenChannelSample.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ const BasicOpenChannelSample = (props) => {
const connectionHandler = new ConnectionHandler();

connectionHandler.onReconnectSucceeded = async () => {
const [messages, error] = await loadMessages(channelToJoin);
const [messages] = await loadMessages(channelToJoin);

updateState({ ...stateRef.current, messages: messages });
}
Expand All @@ -88,7 +88,7 @@ const BasicOpenChannelSample = (props) => {
//listen for incoming messages
const channelHandler = new OpenChannelHandler();
channelHandler.onMessageUpdated = (channel, message) => {
const messageIndex = stateRef.current.messages.findIndex((item => item.messageId == message.messageId));
const messageIndex = stateRef.current.messages.findIndex((item => item.messageId === message.messageId));
const updatedMessages = [...stateRef.current.messages];
updatedMessages[messageIndex] = message;
updateState({ ...stateRef.current, messages: updatedMessages });
Expand Down Expand Up @@ -127,7 +127,7 @@ const BasicOpenChannelSample = (props) => {
}

const handleDeleteChannel = async (channelUrl) => {
const [channel, error] = await deleteChannel(channelUrl);
const [error] = await deleteChannel(channelUrl);
if (error) {
return onError(error);
}
Expand Down Expand Up @@ -188,7 +188,7 @@ const BasicOpenChannelSample = (props) => {
const userMessageUpdateParams = {};
userMessageUpdateParams.message = state.messageInputValue;
const updatedMessage = await currentlyJoinedChannel.updateUserMessage(messageToUpdate.messageId, userMessageUpdateParams)
const messageIndex = messages.findIndex((item => item.messageId == messageToUpdate.messageId));
const messageIndex = messages.findIndex((item => item.messageId === messageToUpdate.messageId));
messages[messageIndex] = updatedMessage;
updateState({ ...state, messages: messages, messageInputValue: "", messageToUpdate: null });
} else {
Expand Down Expand Up @@ -337,10 +337,10 @@ const ChannelList = ({ channels, handleJoinChannel, toggleShowCreateChannel, han
{userIsOperator &&
<div>
<button className="control-button" onClick={() => toggleChannelDetails(channel)}>
<img className="channel-icon" src='/icon_edit.png' />
<img className="channel-icon" src='/icon_edit.png' alt=''/>
</button>
<button className="control-button" onClick={() => handleDeleteChannel(channel.url)}>
<img className="channel-icon" src='/icon_delete.png' />
<img className="channel-icon" src='/icon_delete.png' alt=''/>
</button>
</div>
}
Expand Down Expand Up @@ -387,7 +387,7 @@ const Message = ({ message, updateMessage, handleDeleteMessage }) => {
<div className="oc-message">
<div>{timestampToTime(message.createdAt)}</div>
<div className="oc-message-sender-name">{message.sender.nickname}{' '}</div>
<img src={message.url} />
<img src={message.url} alt=''/>
</div>
);
}
Expand All @@ -402,10 +402,10 @@ const Message = ({ message, updateMessage, handleDeleteMessage }) => {

{messageSentByCurrentUser && <>
<button className="control-button" onClick={() => updateMessage(message)}>
<img className="oc-message-icon" src='/icon_edit.png' />
<img className="oc-message-icon" src='/icon_edit.png' alt=''/>
</button>
<button className="control-button" onClick={() => handleDeleteMessage(message)}>
<img className="oc-message-icon" src='/icon_delete.png' />
<img className="oc-message-icon" src='/icon_delete.png' alt=''/>
</button>
</>}
</div>
Expand Down
17 changes: 8 additions & 9 deletions src/samples/GroupChannelArchive.js
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@

import { useState, useEffect, useRef } from 'react';
import { v4 as uuid } from 'uuid';
import SendbirdChat from '@sendbird/chat';
import {
GroupChannelModule,
Expand Down Expand Up @@ -165,7 +164,7 @@ const GroupChannelArchive = (props) => {
}

const handleCreateChannel = async (channelName = "testChannel",) => {
const [groupChannel, error] = await createChannel(channelName, state.groupChannelMembers);
const [error] = await createChannel(channelName, state.groupChannelMembers);
if (error) {
return onError(error);
}
Expand All @@ -179,7 +178,7 @@ const GroupChannelArchive = (props) => {
}

const handleDeleteChannel = async (channelUrl) => {
const [channel, error] = await deleteChannel(channelUrl);
const [error] = await deleteChannel(channelUrl);
if (error) {
return onError(error);
}
Expand Down Expand Up @@ -256,7 +255,7 @@ const GroupChannelArchive = (props) => {
const userMessageUpdateParams = {};
userMessageUpdateParams.message = state.messageInputValue;
const updatedMessage = await currentlyJoinedChannel.updateUserMessage(messageToUpdate.messageId, userMessageUpdateParams)
const messageIndex = messages.findIndex((item => item.messageId == messageToUpdate.messageId));
const messageIndex = messages.findIndex((item => item.messageId === messageToUpdate.messageId));
messages[messageIndex] = updatedMessage;
updateState({ ...state, messages: messages, messageInputValue: "", messageToUpdate: null });
} else {
Expand All @@ -276,7 +275,7 @@ const GroupChannelArchive = (props) => {

const onFileInputChange = async (e) => {
if (e.currentTarget.files && e.currentTarget.files.length > 0) {
const { currentlyJoinedChannel, messages } = state;
const { currentlyJoinedChannel } = state;
const fileMessageParams = {};
fileMessageParams.file = e.currentTarget.files[0];
currentlyJoinedChannel.sendFileMessage(fileMessageParams)
Expand Down Expand Up @@ -532,7 +531,7 @@ const Message = ({ message, updateMessage, handleDeleteMessage, messageSentByYou
<div className="message-sender-name">{message.sender.nickname}{' '}</div>
<div>{timestampToTime(message.createdAt)}</div>
</div>
<img src={message.url} />
<img src={message.url} alt=''/>
</div>
);
}
Expand All @@ -546,8 +545,8 @@ const Message = ({ message, updateMessage, handleDeleteMessage, messageSentByYou
<div>{timestampToTime(message.createdAt)}</div>
</div>
{messageSentByCurrentUser && <div>
<button className="control-button" onClick={() => updateMessage(message)}><img className="message-icon" src='/icon_edit.png' /></button>
<button className="control-button" onClick={() => handleDeleteMessage(message)}><img className="message-icon" src='/icon_delete.png' /></button>
<button className="control-button" onClick={() => updateMessage(message)}><img className="message-icon" src='/icon_edit.png' alt=''/></button>
<button className="control-button" onClick={() => handleDeleteMessage(message)}><img className="message-icon" src='/icon_delete.png' alt=''/></button>
</div>}
</div>
<div>{message.message}</div>
Expand All @@ -557,7 +556,7 @@ const Message = ({ message, updateMessage, handleDeleteMessage, messageSentByYou

const ProfileImage = ({ user }) => {
if (user.plainProfileUrl) {
return <img className="profile-image" src={user.plainProfileUrl} />
return <img className="profile-image" src={user.plainProfileUrl} alt=''/>
} else {
return <div className="profile-image-fallback">{user.nickname.charAt(0)}</div>;
}
Expand Down
19 changes: 9 additions & 10 deletions src/samples/GroupChannelCategorizeByCustomType.js
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@

import { useState, useEffect, useRef } from 'react';
import { v4 as uuid } from 'uuid';
import SendbirdChat from '@sendbird/chat';
import {
GroupChannelModule,
Expand Down Expand Up @@ -162,7 +161,7 @@ const GroupChannelCategorizeByCustomType = (props) => {
}

const handleCreateChannel = async (channelName = "testChannel",) => {
const [groupChannel, error] = await createChannel(channelName, state.groupChannelMembers);
const [error] = await createChannel(channelName, state.groupChannelMembers);
if (error) {
return onError(error);
}
Expand All @@ -176,7 +175,7 @@ const GroupChannelCategorizeByCustomType = (props) => {
}

const handleDeleteChannel = async (channelUrl) => {
const [channel, error] = await deleteChannel(channelUrl);
const [error] = await deleteChannel(channelUrl);
if (error) {
return onError(error);
}
Expand Down Expand Up @@ -216,7 +215,7 @@ const GroupChannelCategorizeByCustomType = (props) => {
const userMessageUpdateParams = {};
userMessageUpdateParams.message = state.messageInputValue;
const updatedMessage = await currentlyJoinedChannel.updateUserMessage(messageToUpdate.messageId, userMessageUpdateParams)
const messageIndex = messages.findIndex((item => item.messageId == messageToUpdate.messageId));
const messageIndex = messages.findIndex((item => item.messageId === messageToUpdate.messageId));
messages[messageIndex] = updatedMessage;
updateState({ ...state, messages: messages, messageInputValue: "", messageToUpdate: null });
} else {
Expand All @@ -236,7 +235,7 @@ const GroupChannelCategorizeByCustomType = (props) => {

const onFileInputChange = async (e) => {
if (e.currentTarget.files && e.currentTarget.files.length > 0) {
const { currentlyJoinedChannel, messages } = state;
const { currentlyJoinedChannel } = state;
const fileMessageParams = {};
fileMessageParams.file = e.currentTarget.files[0];
currentlyJoinedChannel.sendFileMessage(fileMessageParams)
Expand Down Expand Up @@ -403,7 +402,7 @@ const ChannelList = ({
</div>
<div>
<button className="control-button" onClick={() => handleDeleteChannel(channel.url)}>
<img className="channel-icon" src='/icon_delete.png' />
<img className="channel-icon" src='/icon_delete.png' alt=''/>
</button>
</div>
</div>
Expand Down Expand Up @@ -483,7 +482,7 @@ const Message = ({ message, updateMessage, handleDeleteMessage, messageSentByYou
<div className="message-sender-name">{message.sender.nickname}{' '}</div>
<div>{timestampToTime(message.createdAt)}</div>
</div>
<img src={message.url} />
<img src={message.url} alt=''/>
</div>
);
}
Expand All @@ -498,8 +497,8 @@ const Message = ({ message, updateMessage, handleDeleteMessage, messageSentByYou
</div>
{messageSentByCurrentUser &&
<div>
<button className="control-button" onClick={() => updateMessage(message)}><img className="message-icon" src='/icon_edit.png' /></button>
<button className="control-button" onClick={() => handleDeleteMessage(message)}><img className="message-icon" src='/icon_delete.png' /></button>
<button className="control-button" onClick={() => updateMessage(message)}><img className="message-icon" src='/icon_edit.png' alt=''/></button>
<button className="control-button" onClick={() => handleDeleteMessage(message)}><img className="message-icon" src='/icon_delete.png' alt=''/></button>
</div>
}
</div>
Expand All @@ -510,7 +509,7 @@ const Message = ({ message, updateMessage, handleDeleteMessage, messageSentByYou

const ProfileImage = ({ user }) => {
if (user.plainProfileUrl) {
return <img className="profile-image" src={user.plainProfileUrl} />
return <img className="profile-image" src={user.plainProfileUrl} alt=''/>
} else {
return <div className="profile-image-fallback">{user.nickname.charAt(0)}</div>;
}
Expand Down
Loading

0 comments on commit 9c47179

Please sign in to comment.