Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test looking for LICENSE.txt #85

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Fix test looking for LICENSE.txt #85

merged 1 commit into from
Aug 14, 2019

Conversation

aroach
Copy link
Contributor

@aroach aroach commented Oct 29, 2018

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • The test suite was looking for LICENSE.txt, but it doesn't exist. So, fixed it to look for LICENSE.md.

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 29, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 29, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@crweiner
Copy link
Contributor

This fix was first offered in PR #77 with subsequent changes to the location of the LICENSE file in PR #82.

@thinkingserious thinkingserious merged commit ee8677c into sendgrid:master Aug 14, 2019
@thinkingserious
Copy link
Contributor

Hello @aroach,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aroach @SendGridDX @crweiner @thinkingserious