This repository has been archived by the owner on Aug 20, 2020. It is now read-only.
fix: Fixed failing unit test #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue with the version of nock being used to test and this made tests on node v8 fail. This bumps the version of nock up to that which fixes the bug.
|
|
iifeoluwa
changed the title
iifeoluwa
changed the title
mbernier
added
difficulty: medium
hacktoberfest
difficulty: easy
and removed
difficulty: medium
labels
|
Hello @iifeoluwa, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 25
There was an issue with the version of nock being used to test and this
made tests on node v8 fail.
This bumps the version of nock up to that which fixes the bug.