Skip to content
This repository has been archived by the owner on Aug 20, 2020. It is now read-only.

chore: [issue#52] Added unit tests to check some files exist #55

Merged
merged 1 commit into from
Oct 28, 2017

Conversation

luan-cestari
Copy link
Contributor

@luan-cestari luan-cestari commented Oct 28, 2017

Description of the change:
This PR fulfill the request from issue #52 , which asked to create tests to validate if some files exist

Reason for the change:
The reason behind the request is guarantee that some basic files like README.MD will always be present int he project, so, if it is erased by mistake, the tests will not pass and it will be explicit the problem, without any human manual validation

Link to original source:
The actual source https://github.com/sendgrid/nodejs-http-client/blob/90ca4ebb6e0e6b59bd554908105f66114ad5a8f6/test/test.js

Checklist

Make sure all of these items are complete, or else the PR will be ineligible for a code review.

@SendGridDX
Copy link

SendGridDX commented Oct 28, 2017

CLA assistant check
All committers have signed the CLA.

@mbernier
Copy link
Contributor

BEAUTIFULLY done!

This is awesome. Thank you so much!!

Just so you know, we have this same issue on another Node library if you're interested:

@thinkingserious
Copy link
Contributor

Hello @luan-cestari,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@luan-cestari
Copy link
Contributor Author

Thank you guys =) I hope I can help with other issues in the future

@thinkingserious thinkingserious changed the title [issue#52] Added unit tests to check some files exist chore: [issue#52] Added unit tests to check some files exist Dec 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants