Skip to content
This repository has been archived by the owner on Aug 20, 2020. It is now read-only.

chore: Idiomatic changes reported by CodeClimate #61

Merged
merged 1 commit into from
Nov 1, 2017
Merged

chore: Idiomatic changes reported by CodeClimate #61

merged 1 commit into from
Nov 1, 2017

Conversation

mithunsasidharan
Copy link
Contributor

@mithunsasidharan mithunsasidharan commented Oct 29, 2017

Fixes #49

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@SendGridDX
Copy link

SendGridDX commented Oct 29, 2017

CLA assistant check
All committers have signed the CLA.

@mbernier
Copy link
Contributor

mbernier commented Nov 1, 2017

Codeclimate is happy.
The build is not failing due to your change, it's because files are missing - we added the tests before the files were created :)

@mbernier mbernier merged commit 5bb4cca into sendgrid:master Nov 1, 2017
@thinkingserious
Copy link
Contributor

Hello @mithunsasidharan,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@mithunsasidharan
Copy link
Contributor Author

@thinkingserious : Thank you.. When i submit the swag form, I get the message I don't know who you are; I should, but regretfully I don't. ?

@mbernier
Copy link
Contributor

mbernier commented Nov 1, 2017

@mithunsasidharan Please try going to https://dx.sendgrid.com/swag in incognito mode and logging in using github. My guess is that something went goofy with our page and the github token in your browser.

Report back if you are still having issues and we will look into it!

@mithunsasidharan
Copy link
Contributor Author

mithunsasidharan commented Nov 1, 2017

@mbernier : I tried incognito and also from another browser with a fresh github login but its the same message 😕 ! Can you help ?

@mbernier
Copy link
Contributor

mbernier commented Nov 1, 2017

One last check - did you make sure that you signed into Github from your mithunsasidharan user? We have seen some people who have 2 github users have issues.

If that doesn't work, please send me an email [my github handle at this repo's organization dot com] and we'll make sure you're taken care of.

@mithunsasidharan
Copy link
Contributor Author

@mbernier : I just have a single github account and 1 enterprise github account.. but thats a different domain so I don't think thats got anything to do with this. I confirmed that the email used in the CLA is also the same email that I use for my github account.

@mithunsasidharan
Copy link
Contributor Author

@mbernier : I tried from my mobile too but no luck. I'll drop a mail to you with details ! Thanks much.

@thinkingserious
Copy link
Contributor

@mithunsasidharan,

My apologies! The form has been repaired, could you please try again? Thank you!

With Best Regards,

Elmer

@mithunsasidharan
Copy link
Contributor Author

@thinkingserious : it worked this time! Thanks for the prompt support 👍

@thinkingserious thinkingserious changed the title Idiomatic changes reported by CodeClimate chore: Idiomatic changes reported by CodeClimate Dec 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

idiomatic changes needed, as reported by CodeClimate
4 participants