-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library refactoring around PSR-2 / PSR-4 code standards #6
Conversation
This is awesome @misantron! Could you please sign our CLA so we can get it merged? https://github.com/sendgrid/php-http-client/blob/master/CONTRIBUTING.md#cla |
Thanks for quick response. |
Any problems with PR merge? |
No problems @misantron, Just waiting for it to rise up through the queue for implementation. It can move up the queue faster if others +1 or comment on this thread. Thanks for checking in! |
Finally made it back to this ticket :) Could you please take a moment to check out the merge conflicts? |
# Conflicts: # composer.json
Branch is up to date now and has no conflicts |
Awesome, thanks! There are just a few more tickets ahead of this one now. |
Hello @misantron, I am trying to test out this code before I merge and I have run into an issue. First I ran In the root directory, I created a test.php file with the folloiwng code: <?php
include('./lib/Client.php');
$apiKey = getenv('SENDGRID_API_KEY');
$headers = ['Authorization: Bearer ' . $apiKey];
$client = new SendGrid\Client('https://api.sendgrid.com', $headers, '/v3');
// GET Collection
$response = $client->api_keys()->get();
echo $response->statusCode();
echo $response->body();
echo $response->headers(); When I try to run with Fatal error: Class 'SendGrid\Response' not found in /Users/thinkingserious/Workspace/sendgrid/php-http-client/lib/Client.php on line 128 |
You must include SendGrid\Response class file too or use class autoloader generated via Composer. include('./lib/Response.php'); or require 'vendor/autoload.php'; |
No description provided.