fix: Exclude tests directory from package data #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkingserious
added
the
status: code review request
|
|
thinkingserious
approved these changes
Feb 19, 2020
thinkingserious
changed the title
childish-sambino
pushed a commit
to tysonholub/python-http-client
that referenced
this pull request
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #131
Short description of what this PR does:
setup.py includes all packages (containing an init.py) using find_packages(). This is a problem because it will include the
testsdirectory as a top level importable module in the local app, breaking our own tests that happen to live in a directory with the same name.