Skip to content

Conversation

childish-sambino
Copy link
Contributor

Fixes #144

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Aug 20, 2020
@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #145 into main will increase coverage by 2.51%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   92.62%   95.14%   +2.51%     
==========================================
  Files           6        6              
  Lines         312      309       -3     
==========================================
+ Hits          289      294       +5     
+ Misses         23       15       -8     
Impacted Files Coverage Δ
python_http_client/client.py 89.62% <100.00%> (+7.54%) ⬆️
tests/test_unit.py 99.25% <100.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57ed611...1363840. Read the comment docs.

@childish-sambino childish-sambino merged commit e1c8695 into main Aug 20, 2020
@childish-sambino childish-sambino deleted the fix-logging branch August 20, 2020 21:29
@amanbedi23
Copy link

when will this be updated to the latest pypi package?

@childish-sambino
Copy link
Contributor Author

Released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: code review request requesting a community code review or review from Twilio

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UnboundLocalError: local variable 'exc' referenced before assignment

3 participants