-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker files and update README #50
Conversation
|
README.md
Outdated
> Steps | ||
|
||
1. Install Docker | ||
2. Run `docker-compose up` (This runs tests by default) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe there should be a docker-compose build
step as #2, can you please add that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I LOVE that the build runs the tests. That's awesome.
It would be cool to make a note in the README about changing the run.sh file to another script if they want to run that.
THIS IS AWESOME, btw. |
Hello @NdagiStanley, |
Add docker files and update README
What does this PR do?
Fixes #46
Description of Task to be completed?
Add docker files and updates the Readme to give instruction on how to run it.
How should this be manually tested?
As outlined in the README:
docker
docker-compose up
Note:
I have one line, in the run.sh, what I deem to be the default command for each
docker-compose
run.