Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Gzip compress request body when content-encoding is set to gzip #115

Closed
wants to merge 1 commit into from
Closed

feat!: Gzip compress request body when content-encoding is set to gzip #115

wants to merge 1 commit into from

Conversation

Bankq
Copy link

@Bankq Bankq commented Aug 5, 2023

Fixes

Mail body compression is enabled on V3Mail. This patch added the support in rest package that when a request header has Content-Encoding: gzip set, BulidRequestObject will gzip the request body.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

[Mail body
compression](https://docs.sendgrid.com/api-reference/mail-send/mail-send#mail-body-compression)
is enabled on V3Mail. This patch added the support in `rest` package
that when a request header has `Content-Encoding: gzip` set,
`BulidRequestObject` will gzip the request body.
@Bankq
Copy link
Author

Bankq commented Aug 5, 2023

To be honest I'm not entirely sure if this is appropriate.

My main use case is through https:://github.com/sendgrid/sendgrid-go . Alternatively I can make the change there instead so rest package doesn't modify the passed in body.

@Bankq
Copy link
Author

Bankq commented Aug 6, 2023

Nvm, it turns out that every call in sendgrid-go:Client.Send is public, I can shadow it and bend it to my need.

@Bankq Bankq closed this Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant