Skip to content

Conversation

willnet
Copy link

@willnet willnet commented Oct 2, 2025

  • Add Ruby 3.2, 3.3, 3.4 and JRuby 9.4, 10.0 to CI matrix
  • Remove JRuby 9.2 from CI matrix since setup-ruby on Ubuntu 24.4 only provides builds for JRuby 9.4 and later.
  • Update actions/checkout to the latest
  • Fix a failing test and a lint error

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

- Add Ruby 3.2, 3.3, 3.4 and JRuby 9.4, 10.0.
- Remove JRuby 9.2 since setup-ruby on Ubuntu 24.4 only provides builds for JRuby 9.4 and later.
- Update actions/checkout to the latest
```
  1) Failure:
TestClient#test_license_date_is_updated [/home/runner/work/ruby-http-client/ruby-http-client/test/test_ruby_http_client.rb:398]:
Expected: 2025
  Actual: 2023
```
In Ruby 3.4, base64 is no longer part of the standard library, which was causing the following error.

```
Run bundle exec rake rubocop
  bundle exec rake rubocop
  shell: /usr/bin/bash -e {0}
rubocop -c .rubocop.yml --display-only-fail-level-offenses -D
/home/runner/work/ruby-http-client/ruby-http-client/vendor/bundle/ruby/3.4.0/gems/rubocop-1.24.1/lib/rubocop/formatter/html_formatter.rb:5: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add ostruct to your Gemfile or gemspec to silence this warning.
/home/runner/work/ruby-http-client/ruby-http-client/vendor/bundle/ruby/3.4.0/gems/rubocop-1.24.1/lib/rubocop/formatter/html_formatter.rb:6: warning: base64 was loaded from the standard library, but is not part of the default gems starting from Ruby 3.4.0.
You can add base64 to your Gemfile or gemspec to silence this warning.
/opt/hostedtoolcache/Ruby/3.4.6/x64/lib/ruby/3.4.0/bundled_gems.rb:82:in 'Kernel.require': cannot load such file -- base64 (LoadError)
	from /opt/hostedtoolcache/Ruby/3.4.6/x64/lib/ruby/3.4.0/bundled_gems.rb:82:in 'block (2 levels) in Kernel#replace_require'
	from /home/runner/work/ruby-http-client/ruby-http-client/vendor/bundle/ruby/3.4.0/gems/rubocop-1.24.1/lib/rubocop/formatter/html_formatter.rb:6:in '<top (required)>'
	from /home/runner/work/ruby-http-client/ruby-http-client/vendor/bundle/ruby/3.4.0/gems/rubocop-1.24.1/lib/rubocop.rb:669:in 'Kernel#require_relative'
	from /home/runner/work/ruby-http-client/ruby-http-client/vendor/bundle/ruby/3.4.0/gems/rubocop-1.24.1/lib/rubocop.rb:669:in '<top (required)>'
	from /opt/hostedtoolcache/Ruby/3.4.6/x64/lib/ruby/3.4.0/bundled_gems.rb:82:in 'Kernel.require'
	from /opt/hostedtoolcache/Ruby/3.4.6/x64/lib/ruby/3.4.0/bundled_gems.rb:82:in 'block (2 levels) in Kernel#replace_require'
	from /home/runner/work/ruby-http-client/ruby-http-client/vendor/bundle/ruby/3.4.0/gems/rubocop-1.24.1/exe/rubocop:6:in '<top (required)>'
	from /home/runner/work/ruby-http-client/ruby-http-client/vendor/bundle/ruby/3.4.0/bin/rubocop:25:in 'Kernel#load'
	from /home/runner/work/ruby-http-client/ruby-http-client/vendor/bundle/ruby/3.4.0/bin/rubocop:25:in '<main>'
rake aborted!
Command failed with status (1): [rubocop -c .rubocop.yml --display-only-fail-level-offenses -D]
/home/runner/work/ruby-http-client/ruby-http-client/Rakefile:9:in 'block in <top (required)>'
/home/runner/work/ruby-http-client/ruby-http-client/vendor/bundle/ruby/3.4.0/gems/rake-13.3.0/exe/rake:27:in '<top (required)>'
/opt/hostedtoolcache/Ruby/3.4.6/x64/bin/bundle:25:in 'Kernel#load'
/opt/hostedtoolcache/Ruby/3.4.6/x64/bin/bundle:25:in '<main>'
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant