Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add IsSuccessStatusCode #1077

Merged
merged 2 commits into from
Dec 14, 2020
Merged

feat: add IsSuccessStatusCode #1077

merged 2 commits into from
Dec 14, 2020

Conversation

shoter
Copy link
Contributor

@shoter shoter commented Dec 13, 2020

Fixes

Resolves #1076

A short description of what this PR does.

Introduce new property IsSuccessStatusCode into Response. This property indicates whether given response contains success status code (2xx).

IsSuccessStatusCode is implemented in the same way as HttpResponseMessage.IsSuccessStatusCode

I could not run make test-docker so I made tests that are not using real requests.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@thinkingserious thinkingserious added status: code review request requesting a community code review or review from Twilio type: community enhancement feature request not on Twilio's roadmap and removed status: code review request requesting a community code review or review from Twilio labels Dec 13, 2020
Copy link
Contributor

@thinkingserious thinkingserious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@thinkingserious thinkingserious merged commit a00a259 into sendgrid:main Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add IsSuccessStatusCode to Response type indicating whether respones has 2XX HTTP status code.
2 participants