Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add dockerized email inbound webhook consumer example #789

Merged
merged 9 commits into from
Aug 17, 2020
Merged

feat: Add dockerized email inbound webhook consumer example #789

merged 9 commits into from
Aug 17, 2020

Conversation

KoditkarVedant
Copy link
Contributor

Fixes #766

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file

Short description of what this PR does:

A deployable solution that allows for customers to easily get up and running processing (parse and complete some action) their inbound parse webhooks.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 16, 2018
@devchas devchas added difficulty: very hard fix is very hard in difficulty hacktoberfest status: work in progress Twilio or the community is in the process of implementing type: twilio enhancement feature request on Twilio's roadmap labels Oct 17, 2018
@thinkingserious thinkingserious added status: hacktoberfest approved and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 22, 2018
@thinkingserious
Copy link
Contributor

Hello @KoditkarVedant,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@KoditkarVedant
Copy link
Contributor Author

@thinkingserious Its been month is there anything which is stopping this PR from merging?

@childish-sambino childish-sambino removed the type: twilio enhancement feature request on Twilio's roadmap label Jul 20, 2020
@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:28
@childish-sambino
Copy link
Contributor

Similar comments as #812 regarding license file, .gitignore, references to personal GitHub account, etc.

@KoditkarVedant
Copy link
Contributor Author

@childish-sambino Thank you for your response. I will work over this weekend to resolve the comments & get this PR ready.

@KoditkarVedant
Copy link
Contributor Author

@childish-sambino I've resolved the review comments

@childish-sambino childish-sambino changed the title Add dockerized email inbound webhook consumer feat: Add dockerized email inbound webhook consumer example Aug 17, 2020
@childish-sambino childish-sambino merged commit 6ef4c32 into sendgrid:main Aug 17, 2020
@Jericho Jericho mentioned this pull request Aug 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
difficulty: very hard fix is very hard in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a Dockerized email inbound parse webhook consumer
4 participants
@KoditkarVedant @thinkingserious @childish-sambino @devchas