Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix StyleCop warnings #936

Merged
merged 2 commits into from
Feb 19, 2020
Merged

chore: Fix StyleCop warnings #936

merged 2 commits into from
Feb 19, 2020

Conversation

akunzai
Copy link
Contributor

@akunzai akunzai commented Sep 23, 2019

Fixes StyleCop warnings

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Fix StyleCop warnings
  • Update links

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Sep 23, 2019
aevitas
aevitas approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@aevitas aevitas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's curious to see periods at the end of URLs, but perhaps that's something we can change in the StyleCop configuration later.

LGTM.

@thinkingserious thinkingserious merged commit 94e94f3 into sendgrid:master Feb 19, 2020
@thinkingserious
Copy link
Contributor

Hello @akunzai,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@thinkingserious thinkingserious changed the title Fix StyleCop warnings chore: Fix StyleCop warnings Feb 19, 2020
@akunzai akunzai deleted the fix-stylecop-warnings branch February 19, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkingserious thinkingserious thinkingserious approved these changes

@aevitas aevitas aevitas approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akunzai @thinkingserious @aevitas