Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove char set from content headers for JSON payloads #967

Merged
merged 2 commits into from
Mar 5, 2020
Merged

fix: Remove char set from content headers for JSON payloads #967

merged 2 commits into from
Mar 5, 2020

Conversation

marius-stanescu
Copy link

Fixes #910

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the development branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Removes the character set from the content headers

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jan 17, 2020
thinkingserious
thinkingserious reviewed Jan 17, 2020
View reviewed changes
Copy link
Contributor

@thinkingserious thinkingserious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @marius-stanescu!

src/SendGrid/SendGridClient.cs Outdated Show resolved Hide resolved
@Jericho Jericho mentioned this pull request Jan 31, 2020
Closed
@childish-sambino childish-sambino changed the title #910 Remove char set from content headers fix: Remove char set from content headers for JSON payloads Mar 5, 2020
@childish-sambino childish-sambino merged commit cebe45f into sendgrid:master Mar 5, 2020
@marius-stanescu marius-stanescu deleted the #910 branch March 6, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkingserious thinkingserious thinkingserious left review comments

@hallidev hallidev hallidev left review comments

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contacts API fails with Content-Type application/json; charset=utf-8
4 participants
@marius-stanescu @thinkingserious @hallidev @childish-sambino