Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation Path Incorrect #336

Closed
jverlee opened this issue Dec 20, 2016 · 4 comments
Closed

Documentation Path Incorrect #336

jverlee opened this issue Dec 20, 2016 · 4 comments
Labels
difficulty: easy fix is easy in difficulty status: help wanted requesting help from the community type: bug bug in the library

Comments

@jverlee
Copy link

jverlee commented Dec 20, 2016

Currently documentation and examples include the line:

$sg->client->suppression()->spam_report()->_($email)->...

This is an incorrect end path, returning status code 404. The correct path should be:

$sg->client->suppression()->spam_reports()->...

(with an "s" on the end of "spam report")
@thinkingserious thinkingserious added status: help wanted requesting help from the community type: bug bug in the library labels Jan 26, 2017
@thinkingserious
Copy link
Contributor

Thanks @jverlee!

I've added this to our backlog for a fix.

@jonaswebdev
Copy link

+1

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty hacktoberfest labels Sep 30, 2017
@mrmxs mrmxs mentioned this issue Oct 2, 2017
Merged
@mrmxs
Copy link
Contributor

mrmxs commented Oct 2, 2017

Hello! Please check my PR for this issue)

thinkingserious referenced this issue Oct 4, 2017
@thinkingserious
Merge pull request #435 from mrmxs/issue-#336
b1835dc 
Change spam_report() to spam_reports() in documentation and examples
@valerianpereira
Copy link
Contributor

I have sent a PR for this.

thinkingserious added a commit that referenced this issue Oct 16, 2017
@thinkingserious
Merge pull request #479 from valerianpereira/master
df6944f 
Incorrect documentation path fixed. Issue #336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: help wanted requesting help from the community type: bug bug in the library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@thinkingserious @mbernier @jonaswebdev @valerianpereira @mrmxs @jverlee