Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed serialization of empty JSON objects. #334

Merged
merged 1 commit into from
Mar 4, 2017
Merged

Fixed serialization of empty JSON objects. #334

merged 1 commit into from
Mar 4, 2017

Conversation

Dreyer
Copy link
Contributor

@Dreyer Dreyer commented Dec 2, 2016

Closes #332 and probably #314.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Dec 2, 2016
@thinkingserious
Copy link
Contributor

Awesome! This has been added to our backlog for review and merge. Thanks!

@thinkingserious thinkingserious added the type: bug bug in the library label Dec 8, 2016
@mattastica
Copy link

mattastica commented Mar 2, 2017

Hey @thinkingserious any insight into when this will be merged? It makes setting any false-by-default options to false difficult, which means you can't set mailsettings to the email or else it triggers API errors. Thanks.

@thinkingserious
Copy link
Contributor

Hi @mattastica,

Because we work from a dynamic backlog, it is tough to estimate. However, your vote has been added and this issue is near the top of our backlog.

With Best Regards,

Elmer

@thinkingserious thinkingserious merged commit 450c269 into sendgrid:master Mar 4, 2017
thinkingserious added a commit that referenced this pull request Mar 4, 2017
5.2.3: Pull #334
Fixed serialization of empty JSON objects, fixes #332 & #314
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio type: bug bug in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants