add deploy to heroku button #467
Conversation
thinkingserious
added
the
status: code review request
USE_CASES.md
Outdated
| ## Heroku | ||
| Use the button below to instantly setup your own Simple instance for sending email using sendgrid on Heroku. | ||
|
|
||
| <a href="https://heroku.com/deploy?template=https://github.com/pangaunn/sendgrid-php-heroku"> |
There was a problem hiding this comment.
We need this URL to be hosted in this repo. Could you please make the necessary changes?
There was a problem hiding this comment.
@thinkingserious Are you ok if I push codes in another branch? I have read the heroku document it said it must be root folder, but it supports another branch.
There was a problem hiding this comment.
How about putting the code in /examples/deploy/heroku-hello-email/.
If that does not work, then a branch could work.
There was a problem hiding this comment.
I've created new branch in my forked repository. Could you please create new branch here? so I can make a pull request to new branch.
There was a problem hiding this comment.
I've tried to make it in subfolder like you said. It will mess up your composer.json. We also need to add 2 files in root directory (Procfile and app.json). So I think new branch would be cleaner in this case.
There was a problem hiding this comment.
|
@mbernier As I discussed with @thinkingserious . I've created another PR that has heroku instance detail #477 . |
|
@pangaunn I missed the conversation, it was compressed. Thanks for the heads up! |
|
We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt. Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!) You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged. |
|
Thanks @thinkingserious |
|
Hello @pangaunn, |
#441