Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setGroupsToDisplay's handling of array arguments #625

Conversation

moismailzai
Copy link

@moismailzai moismailzai commented Jun 4, 2018

Fixes #624

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.

Short description of what this PR does:

Fixes #624: Fix setGroupsToDisplay's handling of array arguments

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jun 4, 2018
@SendGridDX
Copy link

SendGridDX commented Jun 4, 2018

CLA assistant check
All committers have signed the CLA.

@thinkingserious
Copy link
Contributor

thinkingserious commented Jun 5, 2018

Hello @moismailzai,

It looks like the tests need to be updated. If you want to give that a go locally, I suggest you use our Docker solution.

Meanwhile, I've added this to our backlog for review.

Thanks!

With Best Regards,

Elmer

@moismailzai
Copy link
Author

hi @thinkingserious, thanks for pointing me in the right direction -- first PR with tests. Looks like the test's control object was catered to the broken behaviour (asm.groups_to_display was wrapped in a secondary array, which would cause a 400 error against the live API). I removed the wrapping array.

@thinkingserious thinkingserious added the type: bug bug in the library label Jun 11, 2018
@thinkingserious
Copy link
Contributor

Thank you! This is now on our backlog for a merge.

@thinkingserious thinkingserious merged commit a511b17 into sendgrid:master Aug 6, 2018
@thinkingserious
Copy link
Contributor

Hello @moismailzai,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@moismailzai
Copy link
Author

Happy to contribute and excited for the the swag -- thank you @thinkingserious !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio type: bug bug in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants