Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isBase64 function fix #668

Merged
merged 1 commit into from
Aug 15, 2018
Merged

isBase64 function fix #668

merged 1 commit into from
Aug 15, 2018

Conversation

thinkingserious
Copy link
Contributor

Fixes #667

@thinkingserious thinkingserious added type: bug bug in the library difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy status: code review request requesting a community code review or review from Twilio labels Aug 15, 2018
@thinkingserious thinkingserious merged commit dce83b3 into master Aug 15, 2018
@thinkingserious
Copy link
Contributor Author

Hello @thinkingserious,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@mikepage
Copy link

mikepage commented Aug 15, 2018

I had to remove the base64_encode function in this line of code in order to keep the attachments readable.

$email->addAttachment(base64_encode(file_get_contents($attachment['tmp_filename'])), 'application/pdf', $attachment['filename'], 'attachment');
PHP version: PHP 7.1.20

@thinkingserious
Copy link
Contributor Author

Thanks for reporting this @mikepage! I've opened an issue here to track.

@childish-sambino childish-sambino deleted the fix-667 branch January 8, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio status: ready for deploy code ready to be released in next deploy type: bug bug in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants