Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allows for a user to utilize self-signed certificates #674

Merged
merged 3 commits into from
Oct 19, 2020

Conversation

davcpas1234
Copy link
Contributor

New Feature

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Allows the ability for a user to utilise self-signed certificates with SendGrid
  • Current Client implementation will fail to process a curl_init() function if, for example, the user is testing the implementation on a local server with an unknown CA
  • See PR here

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Aug 18, 2018
@jpurpura jpurpura added difficulty: easy fix is easy in difficulty type: twilio enhancement feature request on Twilio's roadmap labels Aug 20, 2018
@thinkingserious
Copy link
Contributor

Thanks @davcpas1234! This one is on the backlog for a code review.

@childish-sambino childish-sambino removed the type: twilio enhancement feature request on Twilio's roadmap label Jul 20, 2020
@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:35
@childish-sambino childish-sambino changed the title Update to support self-signed certificates feat: Allows for a user to utilize self-signed certificates Oct 19, 2020
@childish-sambino childish-sambino merged commit 1e47387 into sendgrid:main Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants