Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Adding php static analysis #704

Merged
merged 6 commits into from
Oct 15, 2020
Merged

test: Adding php static analysis #704

merged 6 commits into from
Oct 15, 2020

Conversation

reisraff
Copy link
Contributor

@reisraff reisraff commented Oct 4, 2018

This PR is in order to add a static analyzer, getting errors before run phpunit.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 4, 2018
@agnesjang98 agnesjang98 added hacktoberfest difficulty: medium fix is medium in difficulty labels Oct 11, 2018
@thinkingserious
Copy link
Contributor

Hello @reisraff,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hello @reisraff,

Thanks again for the PR!

We noticed that you have earned 3 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold.

Also, please be sure that you have officially registered here.

Thank you and Happy Hacktobering!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hello @reisraff,

Thanks again for the PR!

You have earned 3 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at dx+hacktoberfest2018@sendgrid.com.

Thank you and Happy Hacktobering!

Team SendGrid

@childish-sambino childish-sambino removed the type: community enhancement feature request not on Twilio's roadmap label Jul 20, 2020
@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:35
@childish-sambino childish-sambino changed the title Adding php static analisys test: Adding php static analysis Oct 15, 2020
@childish-sambino childish-sambino merged commit cbc02c1 into sendgrid:main Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reisraff @thinkingserious @childish-sambino @agnesjang98