Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issue #686 #705

Merged
merged 4 commits into from
May 21, 2019
Merged

Fixing issue #686 #705

merged 4 commits into from
May 21, 2019

Conversation

reisraff
Copy link
Contributor

@reisraff reisraff commented Oct 4, 2018 •
edited by childish-sambino
Loading

Fixes #686

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 4, 2018
peter279k
peter279k reviewed Oct 7, 2018
View reviewed changes
test/unit/MailHelperTest.php Outdated
@@ -70,4 +70,64 @@ public function testEmailName()
'{"name":"\\"O\'Keeffe, John \\\\\\"Billy\\\\\\"\\"","email":"test@example.com"}'
);
}

public function testA()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testA method name is not proper because I don't know this test method actually tests.

Can you name the proper test method name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peter279k done!

@reisraff
Copy link
Contributor Author

reisraff commented Oct 9, 2018

@peter279k done!

@agnesjang98 agnesjang98 added type: bug bug in the library hacktoberfest difficulty: medium fix is medium in difficulty labels Oct 11, 2018
@reisraff
Copy link
Contributor Author

@peter279k could you please approve? Its missing 2 points to win the swag

@peter279k
Copy link
Contributor

peter279k commented Oct 26, 2018 •
edited
Loading

Hi @reisraff, I've approved this, but it seems that test/unit/MailHelperTest.php class has the conflict.
Can you fix that?

@reisraff
Copy link
Contributor Author

@peter279k done!

@thinkingserious
Copy link
Contributor

Hello @reisraff,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious merged commit b1308a9 into sendgrid:master May 21, 2019
@thinkingserious
Copy link
Contributor

Hello @reisraff,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@lode
Copy link

lode commented Nov 27, 2019

Could you please issue a release with this fix? It has been half a year and this patch, as far as I understand, is blocking normal usage of Personalization objects.

See also #882 and #849.

Practically right now we have to construct and end custom json blobs to the API instead of actually using the library if we want to send multiple personalization objects in a proper way. Without it, sending wrong emails or an email with multiple people in the To-header is a little too easy.

@lode lode mentioned this pull request Nov 29, 2019
Closed
@thinkingserious thinkingserious mentioned this pull request Dec 5, 2019
Closed
@thinkingserious thinkingserious mentioned this pull request Mar 7, 2020
Closed
@childish-sambino childish-sambino mentioned this pull request Apr 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peter279k peter279k peter279k approved these changes

Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio type: bug bug in the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NULL Item in Personalizations
5 participants
@reisraff @peter279k @thinkingserious @lode @agnesjang98