-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Box attachment example (issue #481) #743
Conversation
USE_CASES.md
Outdated
'sub' => $boxConfig->enterpriseID, | ||
'box_sub_type' => 'enterprise', | ||
'aud' => 'https://api.box.com/oauth2/token', | ||
'jti' => bin2hex(random_bytes(16)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to official doc, the random_bytes
function supports since php-7.0
version.
And this package still supports the php-5.6
version.
I think this example code should add the notification message to notify someone this sample is only available for php-7.0+
or using other ways to be compatible with php-5.6
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this suggestion I mention should be considered and solved.
Good call, @peter279k. I've updated the function to openssl_random_pseudo_bytes for compatibility. |
@semijoelon, thank you for your reply. If we use the |
58cd62d
to
4fbc370
Compare
4fbc370
to
187c8fe
Compare
Thanks for the suggestion, @peter279k. I have updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the request changes are approved, it looks good to me.
Hello @semijoelon, |
Hello @semijoelon, |
Hello @semijoelon, |
Fixes
Resolves #481
Checklist
Short description of what this PR does:
If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.