Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove dead code when setting the subject #757

Merged

Conversation

2mt-heuser
Copy link
Contributor

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

After a check for type string there is no way to pass in an object of type subject into setSubject() so this check is dead code and can be removed.
Also fixed some minor spelling and codestyle issues in the file

After a check for type string there is no way to pass in an object of type subject
so this check is dead code and can be removed.
Also fixed some minor spelling and codestyle issues in the file
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 24, 2018
@thinkingserious
Copy link
Contributor

Hello @2mt-heuser,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@childish-sambino childish-sambino changed the title Remove dead code when setting the subject fix: remove dead code when setting the subject Jan 8, 2020
@childish-sambino childish-sambino merged commit 494a3fc into sendgrid:master Jan 8, 2020
@thinkingserious
Copy link
Contributor

Hello @2mt-heuser,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants