Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TravisCI deploy improvement #766

Closed
wants to merge 2 commits into from
Closed

TravisCI deploy improvement #766

wants to merge 2 commits into from

Conversation

misantron
Copy link
Contributor

@misantron misantron commented Oct 28, 2018 •
edited
Loading

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 28, 2018
@misantron misantron mentioned this pull request Oct 28, 2018
Merged
6 tasks
peter279k
peter279k approved these changes Oct 29, 2018
View reviewed changes
Copy link
Contributor

@peter279k peter279k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me!

@thinkingserious
Copy link
Contributor

Hello @misantron,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@childish-sambino
Copy link
Contributor

Fixed by #960

@misantron misantron deleted the travis-config-update-patch branch July 3, 2020 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peter279k peter279k peter279k approved these changes

Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@misantron @thinkingserious @childish-sambino @peter279k