Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Incorrect links in Use Cases, section Email Stats #980

Merged
merged 9 commits into from
Nov 10, 2020
Merged

docs: Incorrect links in Use Cases, section Email Stats #980

merged 9 commits into from
Nov 10, 2020

Conversation

kampalex
Copy link
Contributor

@kampalex kampalex commented Jun 15, 2020 •
edited
Loading

Fix incorrect links of Use Cases: Email Stats
The links were pointing to (app.)example.com instead of (app.)sendgrid.com.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the master branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

kampalex added 7 commits May 19, 2020 15:38
@kampalex
Merge pull request #1 from sendgrid/master
d82606b 
Updated code base from upstream repository
@kampalex
Merge pull request #2 from sendgrid/master
b2520ac 
Update repository using sendgrid/master
@kampalex
Merge pull request #3 from sendgrid/master
a2e30cb 
Sync local repository using original
@kampalex
Merge pull request #4 from sendgrid/master
0abb577 
Update repository using sendgrid/master
@kampalex
Merge pull request #5 from sendgrid/master
7cbf642 
Sync local repository using original
@kampalex
Merge pull request #6 from sendgrid/master
76b2c71 
Sync local repository using original
@kampalex
Fix broken links of Use Cases: Email Stats (were pointing to (...)exa…
fe030b2 
…mple.com(...))
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jun 15, 2020
@eshanholtz eshanholtz changed the title fix: Incorrect links in Use Cases, section Email Stats docs: Incorrect links in Use Cases, section Email Stats Jun 16, 2020
eshanholtz
eshanholtz approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@eshanholtz eshanholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing!

@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:34
@childish-sambino childish-sambino merged commit 8a7d598 into sendgrid:main Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshanholtz eshanholtz eshanholtz approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kampalex @eshanholtz @thinkingserious @childish-sambino