Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typography on mail helper refactor proposal #353

Merged
merged 2 commits into from
Dec 16, 2017
Merged

Fix typography on mail helper refactor proposal #353

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
162d7e3
Fix typography on mail helper refactor proposal
yothinix Oct 3, 2017
f01124e
Change back to plural as comment
yothinix Dec 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions proposals/mail-helper-refactor.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ global_substitutions = {
'-time-': strftime("%Y-%m-%d %H:%M:%S", gmtime())
}
msg = Mail(from_email=From('from@example.com', 'From Name'),
to_emails=tos,
to_emails=to_emails,
subject=Subject('Hi -name-'),
plain_text_content=PlainTextContent('Hello -name-, your github is -github-, email sent at -time-'),
html_content=HtmlContent('<strong>Hello -name-, your github is <a href=\"-github-\">here</a></strong> email sent at -time-'),
Expand All @@ -105,7 +105,7 @@ import sendgrid
from sendgrid.helpers.mail import *

msg = Mail(from_email=From('from@example.com', 'From Name'),
to_email=To('to@example.com', 'To Name'),
to_emails=To('to@example.com', 'To Name'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a single email address, should it stay singular?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it should stay singular in this case.

subject=Subject('Sending with SendGrid is Fun'),
plain_text_content=PlainTextContent('and easy to do anywhere, even with Python'),
html_content=HtmlContent('<strong>and easy to do anywhere, even with Python</strong>'))
Expand Down Expand Up @@ -175,7 +175,7 @@ msg.bcc = [

msg.header = Header('X-Test5', 'Test5', p=1)
msg.header = Header('X-Test6', 'Test6', p=1)
msg.headers = [
msg.header = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be multiple headers, should it stay plural?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should stay plural in that case.

Header('X-Test7', 'Test7', p=1),
Header('X-Test8', 'Test8', p=1)
]
Expand Down Expand Up @@ -228,7 +228,7 @@ msg.attachment = [
msg.template_id = TemplateId('13b8f94f-bcae-4ec6-b752-70d6cb59f932')

msg.global_header = Header('X-Day', 'Monday')
msg.global_headers = [
msg.global_header = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be multiple headers, should it stay plural?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should remain plural.

Header('X-Month', 'January'),
Header('X-Year': '2017')
]
Expand Down