Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use case for generation of Plain Text Content from HTML #665

Merged
merged 1 commit into from
Dec 7, 2018

Conversation

cmccandless
Copy link
Contributor

@cmccandless cmccandless commented Oct 9, 2018

Fixes #354

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master v4 branch.
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 9, 2018
@codecov
Copy link

codecov bot commented Oct 9, 2018

Codecov Report

Merging #665 into v4 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               v4     #665   +/-   ##
=======================================
  Coverage   84.35%   84.35%           
=======================================
  Files          36       36           
  Lines         965      965           
  Branches      107      107           
=======================================
  Hits          814      814           
  Misses         93       93           
  Partials       58       58

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edd02e4...1819e60. Read the comment docs.

@agnesjang98 agnesjang98 added hacktoberfest difficulty: medium fix is medium in difficulty type: twilio enhancement feature request on Twilio's roadmap labels Oct 11, 2018
@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing and removed status: code review request requesting a community code review or review from Twilio labels Oct 19, 2018
@thinkingserious thinkingserious added status: waiting for feedback waiting for feedback from the submitter status: hacktoberfest approved and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 23, 2018
@thinkingserious
Copy link
Contributor

Hello @cmccandless,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hello @cmccandless,

Could you please merge this against our v4 branch? Thank you!

With Best Regards,

Elmer

@cmccandless
Copy link
Contributor Author

cmccandless commented Oct 23, 2018

@thinkingserious

Could you please merge this against our v4 branch? Thank you!

Done. This PR was already merging against that branch, but I did rebase against the latest commits in v4.

@thinkingserious
Copy link
Contributor

Hello @cmccandless,

Thanks again for the PR!

You have earned 10 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at dx+hacktoberfest2018@sendgrid.com.

Thank you and Happy Hacktobering!

Team SendGrid

@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing and removed status: waiting for feedback waiting for feedback from the submitter labels Oct 31, 2018
@cmccandless
Copy link
Contributor Author

Labels indicate that something further is expected of me, but I have already rebased against v4, and there are no requested changes. Is there anything else needed from me?

@thinkingserious thinkingserious added status: code review request requesting a community code review or review from Twilio and removed status: work in progress Twilio or the community is in the process of implementing labels Dec 7, 2018
@thinkingserious
Copy link
Contributor

Thanks for the heads up @cmccandless, this PR has been updated accordingly.

@thinkingserious thinkingserious merged commit 0282aab into sendgrid:v4 Dec 7, 2018
@thinkingserious
Copy link
Contributor

Hello @cmccandless,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@cmccandless cmccandless deleted the issue-354 branch December 7, 2018 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants