Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Further Remove "Whitelabel" References #734

Merged
merged 4 commits into from
Mar 6, 2020

Conversation

crweiner
Copy link
Contributor

@crweiner crweiner commented Nov 5, 2018

Please see pull request #687 and Issue #686

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

I had missed some additional references to "whitelabeling" services initially, thus pull request #687 did not end up fixing all the verbiage issues when it was merged.

I have gone back and further changed the references to "whitelabeling" that I had missed (sorry about that!!!)

Signed-off-by: chandler <chandler@chandlerweiner.com>
Signed-off-by: chandler <chandler@chandlerweiner.com>
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 5, 2018
@codecov
Copy link

codecov bot commented Nov 5, 2018

Codecov Report

Merging #734 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #734   +/-   ##
=======================================
  Coverage   82.48%   82.48%           
=======================================
  Files          70       70           
  Lines        2312     2312           
  Branches      340      340           
=======================================
  Hits         1907     1907           
  Misses        206      206           
  Partials      199      199

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2ca1f4...90d5bfd. Read the comment docs.

@childish-sambino childish-sambino changed the title Further Remove "Whitelabel" References docs: Further Remove "Whitelabel" References Mar 6, 2020
@childish-sambino childish-sambino merged commit c114681 into sendgrid:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants