Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set version env var for tests #479

Merged
merged 16 commits into from
Feb 4, 2022
Merged

fix: set version env var for tests #479

Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b5a19bd
fix: set ruby version for tests
Feb 2, 2022
82628ea
add docker login
Feb 2, 2022
04d84e4
set up ruby in workflow again
Feb 2, 2022
0f22f8a
rewrite version labels
Feb 2, 2022
df58755
^
Feb 2, 2022
60b6575
fix rubocop exclusion
Feb 2, 2022
0f3138c
take out setup step
Feb 2, 2022
d709058
readd setup step & wrap versions in quotes
Feb 2, 2022
b383983
take out setup step again
Feb 2, 2022
d021b0d
concatenate ruby: to version env var
Feb 3, 2022
795ab53
fix typo
Feb 3, 2022
ef798c4
fix equality check
Feb 3, 2022
a45d8e2
revise env version if necessary
Feb 3, 2022
50151c4
^
Feb 3, 2022
efe4c59
jruby: instead of jruby-
Feb 3, 2022
988a673
Merge branch 'main' into set-test-version
Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion .github/workflows/test-and-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,14 @@ jobs:
timeout-minutes: 20
strategy:
matrix:
ruby: [ 2.4, 2.5, 2.6, 2.7, 3.0, jruby-9.2 ]
ruby: [ '2.4', '2.5', '2.6', '2.7', '3.0', jruby-9.2 ]
env:
version: ${{ format('ruby:{0}', matrix.ruby) }}
steps:
- name: Revise env version if necessary
run: echo "version=jruby:9.2" >> $GITHUB_ENV
if: ${{ matrix.ruby == 'jruby-9.2' }}

- name: Checkout sendgrid-ruby
uses: actions/checkout@v2
with:
Expand All @@ -30,6 +36,12 @@ jobs:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true

- name: Login to Docker Hub
uses: docker/login-action@v1
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_AUTH_TOKEN }}

- run: make install

- name: Set up linter
Expand Down