Skip to content

Fix sending with attachment API through Json Serializer #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 7, 2018
Merged

Fix sending with attachment API through Json Serializer #4

merged 4 commits into from
Mar 7, 2018

Conversation

mimiiix
Copy link
Contributor

@mimiiix mimiiix commented Mar 6, 2018 •
edited
Loading

Fix sending with attachment API through Json Serializer

  • Added a TypeAdapter to handle Base64 encoded data in Json Serializer and Deserializer
  • Base64 is now handled in API side
  • User need only to add the byte array of his attachment

@mimiiix mimiiix requested a review from ekta-slit March 6, 2018 09:10
ekta-slit
ekta-slit approved these changes Mar 6, 2018
View reviewed changes
Copy link
Collaborator

@ekta-slit ekta-slit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mimiiix mimiiix merged commit 0c20b3c into master Mar 7, 2018
@ekta-slit ekta-slit deleted the hotfix-byteattachment branch March 7, 2018 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekta-slit ekta-slit ekta-slit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mimiiix @ekta-slit