Skip to content

Mixed specification updates #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2018
Merged

Mixed specification updates #5

merged 1 commit into from
Mar 23, 2018
+533 −281

Conversation

ekta-slit
Copy link
Collaborator

  • Add/Remove contact to list schema update & method name changed
  • Removed tag & from from the response schema definition of getEmailEventReport as mandatory fields
  • Fix type: object field in getSmsCampaign & getEmailCampaign definition for good response in get email/sms campaigns
  • Added templateId & params as new input in sendSmtpEmail definition
  • Renaming of some method names

@ekta-slit ekta-slit force-pushed the feature_mixed-spec-updates branch from cbd9aa2 to 089a4cf Compare March 23, 2018 09:30
@ekta-slit ekta-slit force-pushed the feature_mixed-spec-updates branch from 089a4cf to 67544a8 Compare March 23, 2018 09:32
aakanksha-sib
aakanksha-sib approved these changes Mar 23, 2018
View reviewed changes
Copy link

@aakanksha-sib aakanksha-sib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ekta-slit ekta-slit merged commit 4fc4a72 into master Mar 23, 2018
@ekta-slit ekta-slit deleted the feature_mixed-spec-updates branch March 23, 2018 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aakanksha-sib aakanksha-sib

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ekta-slit @aakanksha-sib