Skip to content

AP-1036: Making IP non mandatory for get_contact_details #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2020
Merged

AP-1036: Making IP non mandatory for get_contact_details #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d16762e
AP-1036: Making IP non mandatory for get_contact_details
ruudy-sib Oct 16, 2020
d312540
AP-1036: Update version of the package
ruudy-sib Oct 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/GetExtendedContactDetailsStatisticsUnsubscriptionsAdminUnsubscription.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
Name | Type | Description | Notes
------------ | ------------- | ------------- | -------------
**event_time** | **datetime** | UTC date-time of the event |
**ip** | **str** | IP from which the user has been unsubscribed |
**ip** | **str** | IP from which the user has been unsubscribed | [optional]

[[Back to Model list]](../README.md#documentation-for-models) [[Back to API list]](../README.md#documentation-for-api-endpoints) [[Back to README]](../README.md)

Expand Down
2 changes: 1 addition & 1 deletion docs/GetExtendedContactDetailsStatisticsUnsubscriptionsUserUnsubscription.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Name | Type | Description | Notes
------------ | ------------- | ------------- | -------------
**campaign_id** | **int** | ID of the campaign which generated the event |
**event_time** | **datetime** | UTC date-time of the event |
**ip** | **str** | IP from which the user has unsubscribed |
**ip** | **str** | IP from which the user has unsubscribed | [optional]

[[Back to Model list]](../README.md#documentation-for-models) [[Back to API list]](../README.md#documentation-for-api-endpoints) [[Back to README]](../README.md)

Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from setuptools import setup, find_packages # noqa: H301

NAME = "sib-api-v3-sdk"
VERSION = "6.3.0"
VERSION = "6.3.1"
# To install the library, run the following
#
# python setup.py install
Expand Down
5 changes: 2 additions & 3 deletions ...dk/models/get_extended_contact_details_statistics_unsubscriptions_admin_unsubscription.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ def __init__(self, event_time=None, ip=None): # noqa: E501
self.discriminator = None

self.event_time = event_time
self.ip = ip
if ip is not None:
self.ip = ip

@property
def event_time(self):
Expand Down Expand Up @@ -95,8 +96,6 @@ def ip(self, ip):
:param ip: The ip of this GetExtendedContactDetailsStatisticsUnsubscriptionsAdminUnsubscription. # noqa: E501
:type: str
"""
if ip is None:
raise ValueError("Invalid value for `ip`, must not be `None`") # noqa: E501

self._ip = ip

Expand Down
5 changes: 2 additions & 3 deletions ...sdk/models/get_extended_contact_details_statistics_unsubscriptions_user_unsubscription.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ def __init__(self, campaign_id=None, event_time=None, ip=None): # noqa: E501

self.campaign_id = campaign_id
self.event_time = event_time
self.ip = ip
if ip is not None:
self.ip = ip

@property
def campaign_id(self):
Expand Down Expand Up @@ -124,8 +125,6 @@ def ip(self, ip):
:param ip: The ip of this GetExtendedContactDetailsStatisticsUnsubscriptionsUserUnsubscription. # noqa: E501
:type: str
"""
if ip is None:
raise ValueError("Invalid value for `ip`, must not be `None`") # noqa: E501

self._ip = ip

Expand Down