Skip to content
This repository has been archived by the owner on Dec 23, 2023. It is now read-only.

add CURRENT_PROJECT_VERSION to Release target to prevent ITMS-90056 #9

Merged
merged 1 commit into from
Mar 16, 2019

Conversation

nimajalali
Copy link
Contributor

When importing using Carthage the SDK works fine during development but during distribution the App Store rejects the upload.

App Store Connect Operation Error
	ERROR ITMS-90056: "This bundle Payload/SomeApp.app/Frameworks/Swime.framework is invalid. The Info.plist file is missing the required key: CFBundleVersion."

Since Swime sets the bundle version to $(CURRENT_PROJECT_VERSION) I set the CURRENT_PROJECT_VERSION to be 1 during Release builds.

I've confirmed this resolves the issue but I'm not sure if this is the right approach.

I looked around at some other frameworks and it seems that many just set CURRENT_PROJECT_VERSION to 1 during Release
https://github.com/Alamofire/Alamofire/blob/master/Alamofire.xcodeproj/project.pbxproj#L1808
https://github.com/PureLayout/PureLayout/blob/master/PureLayout/PureLayout.xcodeproj/project.pbxproj#L1553

@sendyhalim
Copy link
Owner

Sorry for super late reply.
Hmm I'm not sure about this too, I'm merging this since it wouldn't hurt Swime project to have it set to 1

@sendyhalim sendyhalim merged commit 09bf6bf into sendyhalim:master Mar 16, 2019
@sendyhalim
Copy link
Owner

@nimajalali I just released a new version 3.0.5 https://github.com/sendyhalim/Swime/releases/tag/3.0.5, could you please try it? Feel free to re-open the issue. Thanks a lot!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants