This repository has been archived by the owner on Dec 23, 2023. It is now read-only.
add CURRENT_PROJECT_VERSION to Release target to prevent ITMS-90056 #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing using Carthage the SDK works fine during development but during distribution the App Store rejects the upload.
Since Swime sets the bundle version to
$(CURRENT_PROJECT_VERSION)
I set theCURRENT_PROJECT_VERSION
to be 1 during Release builds.I've confirmed this resolves the issue but I'm not sure if this is the right approach.
I looked around at some other frameworks and it seems that many just set CURRENT_PROJECT_VERSION to 1 during Release
https://github.com/Alamofire/Alamofire/blob/master/Alamofire.xcodeproj/project.pbxproj#L1808
https://github.com/PureLayout/PureLayout/blob/master/PureLayout/PureLayout.xcodeproj/project.pbxproj#L1553