Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Refactor classes -> factory functions #73

Merged
merged 24 commits into from
Jan 12, 2017
Merged

Conversation

nfantone
Copy link
Collaborator

@nfantone nfantone commented Dec 12, 2016

  • Avoid using class or new.
  • Reduce usage of this.
  • Favor composition and factory functions.
  • Expand documentation all around.
  • No API changes.

TODO

This is not to be merged until all of below are done and dusted:

  • Improve jsdocs.
  • Adapt and fix unit tests (make CI test pass).
  • Add functional, end to end tests using rabbitmq on Travis.

@nfantone nfantone self-assigned this Dec 12, 2016
@codecov-io
Copy link

codecov-io commented Jan 8, 2017

Current coverage is 100% (diff: 100%)

Merging #73 into develop will not change coverage

@@           develop   #73   diff @@
====================================
  Files            4    10     +6   
  Lines          120   197    +77   
  Methods         22    38    +16   
  Messages         0     0          
  Branches        13    26    +13   
====================================
+ Hits           120   197    +77   
  Misses           0     0          
  Partials         0     0          

Powered by Codecov. Last update d11eb32...7b1fae9

@nfantone nfantone merged commit b7a645e into develop Jan 12, 2017
@nfantone nfantone deleted the enhancement/no-classes branch January 12, 2017 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants