Prepare for release #99
Conversation
|
|
||
| jobs: | ||
| build: | ||
| timeout-minutes: 4 |
There was a problem hiding this comment.
Having a timeout is very important. For example, on my personal account yesterday, while I was testing a GitHub actions setup, I had a test suite hang. That used up all of free tier minutes for my account which caught me completely unawares - the default timeout is 6 hours.
lilsweetcaligula
force-pushed
the
prepare-for-release
branch
from
4740911
to
beb61c2
Compare
lilsweetcaligula
force-pushed
the
prepare-for-release
branch
from
abe8e8a
to
412dd19
Compare
|
|
||
| jobs: | ||
| build: | ||
| timeout-minutes: 4 |
lib/intern.js
Outdated
| const qq = {} | ||
|
|
||
| for (const qp in q) { | ||
| if (is_seneca_qualifier(qp)) { |
There was a problem hiding this comment.
use "directive", not "qualifier"
"directive" is the terminology established in the Seneca docs for $ props that do special things
lib/intern.js
Outdated
| } | ||
|
|
||
|
|
||
| if (is_mongo_qualifier(qp)) { |
There was a problem hiding this comment.
and mongo must have their own term for "qualifier" too - see if you can find a reference in the mongo docs
mongo-store.js
Outdated
|
|
||
| /* | ||
| native$ = object => use object as query, no meta settings | ||
| native$ = array => use first elem as query, second elem as meta settings | ||
| */ | ||
|
|
||
| module.exports = function (opts) { | ||
| const mongoStore = function (opts) { |
There was a problem hiding this comment.
use:
const mongo_store = function mongo_store(options) {
this updates the names to be consistent with standard usage:
- the name of the plugin function is significant - Seneca uses if for the plugin name in logs (until overridden by exports)
- plugin options should always be called
optionsfor consistency - the const variable should have the same name as the function
#98 #97 #96 #95 #94 #93 #92 #91 #90