Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated depreciated np.int too np.int_ #15

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sw241395
Copy link

Still new to contributing to open source, if you want me to make any edits to this PR then feel free to let me know.

@sw241395
Copy link
Author

I was planning on implementing the ability to have more than 26 number of cuts for SAX but am limited as the output of the method is string and it may get confusing between a SAX representation of ['a', 'a', 'b', 'a'] and ['a', 'ab', 'a']. You could change it so that you return a list of strings rather than a single string, therefore you are not limited too 26 cuts.

Copy link

@m0odero m0odero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to accelerate the merging of this change so we can effectively use it? It's currently throwing errors and it's impossible to move on without this. I would also suggest that we use int64/int32 instead of int_

@sw241395
Copy link
Author

Have updated int_ too int64, is this ok?

@m0odero
Copy link

m0odero commented May 29, 2023

Have updated int_ too int64, is this ok?

This is okay. I'll test and revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants