Skip to content

Commit

Permalink
set Github branch to master
Browse files Browse the repository at this point in the history
  • Loading branch information
Piet Bos committed Jul 25, 2017
1 parent d5b37ab commit 5aced21
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion so-clean-up-wp-seo.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
* Text Domain: so-clean-up-wp-seo
* Network: true
* GitHub Plugin URI: https://github.com/senlin/so-clean-up-wp-seo
* GitHub Branch: develop
* GitHub Branch: master
*/

// don't load the plugin file directly
Expand Down

9 comments on commit 5aced21

@afragen
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the next version of GitHub Updater the branch header won't be needed. Branches will be set in install or branch switching.

@senlin
Copy link
Owner

@senlin senlin commented on 5aced21 Jul 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, thanks for sharing that news!
Will you make documentation available on how to add or set this then? Or is nothing at all needed?
When are you planning on releasing this?

@afragen
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently in the develop branch, which still has the header. The header is ignored. Setting default is master, branch only sets during an install or branch switch. This means that if you currently have a branch other than master that you are using on a site. You will need to do a branch switch to re-install it and set the branch.

I’m counting this as a breaking change.

@afragen
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/afragen/github-updater/wiki/Versions-and-Branches#branch-switching-via-wordpress-admin

@senlin
Copy link
Owner

@senlin senlin commented on 5aced21 Jul 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, but this stuff goes a bit over my head.

@afragen
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry. Just know that if you're using a branch other than master you'll need to reinstall using the branch switcher.

@senlin
Copy link
Owner

@senlin senlin commented on 5aced21 Jul 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry. Just know that if you're using a branch other than master you'll need to reinstall using the branch switcher.

Reinstall what and where?

@afragen
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reinstall whatever plugin or theme you're using that's getting updates off a non-master branch.

The reinstall is just a branch switch to the same branch.

@senlin
Copy link
Owner

@senlin senlin commented on 5aced21 Jul 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay, I see that we're talking 2 different things here. What you mean is that a plugin that is being updated by your Updater script needs to be re-installed.

I thought you were referring to how I need to do something to the Hide SEO Bloat plugin.

Please sign in to comment.