DV: Fix REPLACE tiles never being selected in some cases #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we produce mesh tilesets, we usually end up creating a fake root tile to hold many children. This tile will have the
ADD
refinement strategy which meant that we would display the mesh properly.However, in some cases, we end up with a singular root tile if the file is particularly simple (as seen here). In this case, the root tile has a
REPLACE
refinement strategy, and so we will add aTile3D
to theselectedTileGroups
rather than aTileGroup3D
. This means that our replacement handling code will get stuck and throw the warnings that we've seen on a few projects. This would result in us downloading but never actually displaying the child tiles content (as it would never be selected properly).Instead, we only set the
selectedTileGroups
values for non-REPLACE
tiles.Before:
After: