Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DV: Fix REPLACE tiles never being selected in some cases #13

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

Kaapp
Copy link

@Kaapp Kaapp commented Sep 4, 2024

When we produce mesh tilesets, we usually end up creating a fake root tile to hold many children. This tile will have the ADD refinement strategy which meant that we would display the mesh properly.

However, in some cases, we end up with a singular root tile if the file is particularly simple (as seen here). In this case, the root tile has a REPLACE refinement strategy, and so we will add a Tile3D to the selectedTileGroups rather than a TileGroup3D. This means that our replacement handling code will get stuck and throw the warnings that we've seen on a few projects. This would result in us downloading but never actually displaying the child tiles content (as it would never be selected properly).

Instead, we only set the selectedTileGroups values for non-REPLACE tiles.

Before:
image

After:
image

@Kaapp Kaapp self-assigned this Sep 4, 2024
Copy link

@Gmadges Gmadges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

Copy link
Member

@Rennzie Rennzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants