Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DV: Fix replace tiles with no children not loading #14

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

Kaapp
Copy link

@Kaapp Kaapp commented Sep 4, 2024

Merged previous PR slightly too hastily 😬

Cypress found an interesting edge case which is a file like EdenbridgeBox.ifc which is a single root node with no children AND a REPLACE refinement. This doesn't really many any sense, but we still need to handle it otherwise we won't be able to display the model.

Original file still works:
image

Edenbridge box is also back:
image

@Kaapp Kaapp self-assigned this Sep 4, 2024
@Kaapp Kaapp merged commit d7e1179 into master Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants