Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--screenshot-filter option #266

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

helviojunior
Copy link

@helviojunior helviojunior commented Jan 1, 2025

Re-implementation of option --screenshot-filter to solve the Issue #264

Copy link
Member

@leonjza leonjza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you take a look at the proposed changes, and also implement this for the go-rod driver?

Thanks!

cmd/scan.go Outdated Show resolved Hide resolved
pkg/runner/drivers/chromedp.go Outdated Show resolved Hide resolved
pkg/runner/drivers/chromedp.go Outdated Show resolved Hide resolved
@helviojunior
Copy link
Author

Thanks for the PR! Could you take a look at the proposed changes, and also implement this for the go-rod driver?

Thanks!

Implemented!

@helviojunior helviojunior requested a review from leonjza February 3, 2025 12:33
@helviojunior
Copy link
Author

BTW: Congrats to amazing project and code! It was my first contact developing with GoLang. And I used your code as inspiration to another project (https://github.com/helviojunior/sprayshark/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants