Fix incorrect argument list quoting in POSIX systems #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use only shlex for POSIX systems and only subprocess.list2cmdline for NT. According to https://bugs.python.org/issue37659 shlex and list2cmdline are not coherent with each other so using them in conjunction may lead to quoting correct neigher in Unix nor in Windows. One simple example is 'app 1.apk'. It will be quoted once by shlex ("'app 1.apk'") and another time by cmdline resulting in mad "\"'app 1.apk'\"". Removing shlex won't help because of bug sensepost#234. At the same time shlex won't work with NT (python bug 37659), so the only reasonable fix is splitting them based on the OS.
|
Amazing! Thanks! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use only shlex for POSIX systems and only subprocess.list2cmdline for NT.
According to https://bugs.python.org/issue37659 shlex and list2cmdline are
not coherent with each other so using them in conjunction may lead to
quoting correct neigher in Unix nor in Windows.
One simple example is 'app 1.apk'. It will be quoted once by shlex
(
"'app 1.apk'") and another time by cmdline resulting in mad"\"'app 1.apk'\"". Removing shlex won't help because of bug #234. At the sametime shlex won't work with NT (python bug 37659), so the only reasonable fix
is splitting them based on the OS.