Streamlining error handling when --skip-resources is set #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Neat thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
objection patchapk currently does not work well when --skip-resources is set. Especially since the addition of --ignore-nativelibs, objection patchapk does not work at all with --skip-resources unless --ignore-nativelibs is set.
In order to improve the situation somewhat, objection patchapk now handles a missing --ignore-nativelibs similar to a given --enable-debug and prints an incompatibility warning. Also, the check for skip_resources within AndroidPatcher has been moved into the _get_android_manifest function to avoid checks all over the place.