Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove legacy version conflict #449

Merged
merged 3 commits into from Apr 6, 2021
Merged

remove legacy version conflict #449

merged 3 commits into from Apr 6, 2021

Conversation

ghost
Copy link

@ghost ghost commented Apr 3, 2021

removes the conflicts of legacy versions , here is an example of the bug:
image

@leonjza
Copy link
Member

leonjza commented Apr 4, 2021

Thanks for this PR! I have actually been thinking we should introduce python-semver for this. I worry a little with LooseVersion not being documented it might be a little unpredictable vs a maintained library.

Want to take a stab at doing that?

@ghost
Copy link
Author

ghost commented Apr 4, 2021

sure, looking into it right away

@leonjza leonjza merged commit 554c6c6 into sensepost:master Apr 6, 2021
@leonjza
Copy link
Member

leonjza commented Apr 6, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant