forked from saltstack-formulas/docker-formula
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using releases from github instead of bintray #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Further reason is to avoid issues with `rst-lint`: ``` ERROR docs/CONTRIBUTING_DOCS.rst:29 Unknown interpreted text role "ref". WARNING docs/CONTRIBUTING_DOCS.rst:40 malformed hyperlink target. ERROR docs/index.rst:10 Unknown directive type "toctree". ```
Retrieve binary releases from github instead of bintray
## [2.0.4](v2.0.3...v2.0.4) (2021-05-19) ### Bug Fixes * **config:** replace URLs to bintray.com by github.com ([2f60c21](2f60c21)) * **config:** use 'latest' docker-compose versions from github ([d434e25](d434e25)) ### Continuous Integration * add `arch-master` to matrix and update `.travis.yml` [skip ci] ([cec557a](cec557a)) ### Documentation * remove files which aren't formula-specific [skip ci] ([4cc1e70](4cc1e70)) * **readme:** fix headings and links [skip ci] ([b0021eb](b0021eb))
With use_upstream: repo, several errors occur: - An invalid state id is used to require the repo state - An incorrect path to include the repo state is used - A dictionary with conifguration is incorrectly passed to the onlyif statement, which is already checked by the if-statement around it.
The clean failed due to a mismatch of the name of the repo that was installed.
A dictionary is passed to the salt 'onlyif' condition. This is invalid syntax and the condition is already checked by in the jinja around it.
fix(clean): fix syntax error with use_upstream repo
## [2.0.5](v2.0.4...v2.0.5) (2021-05-20) ### Bug Fixes * **clean:** fix clean of repo for the RedHat family ([4730a72](4730a72)) * **clean:** fix syntax error in networks.clean state file ([53db7ad](53db7ad)) * **clean:** fix syntax error with use_upstream repo ([428dccd](428dccd)) * **clean:** make repo install and clean states consistent ([af16bb7](af16bb7)) * **clean:** remove invalid 'onlyif' statement from repo.clean ([b3c56cb](b3c56cb)) * **clean:** update condition that enables the repo ([1f5190b](1f5190b)) * **clean:** update enable_repo condition to be more robust ([a7f382f](a7f382f)) * **test:** add missing tests to verify installation from repo ([5a62de9](5a62de9)) ### Continuous Integration * **kitchen:** use `master` as default instance for Arch Linux [skip ci] ([161d8cc](161d8cc))
…nfiguration_change fix(service): reload the docker service when daemon.json has changed
## [2.0.6](v2.0.5...v2.0.6) (2021-05-21) ### Bug Fixes * **service:** reload the docker service when daemon.json has changed ([b34f434](b34f434))
fix(clean): fix syntax error in networks.clean
## [2.0.7](v2.0.6...v2.0.7) (2021-06-02) ### Bug Fixes * **clean:** fix syntax error in networks.clean ([89cd4fc](89cd4fc))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that Jfrog has shutdown bintray: https://www.infoq.com/news/2021/02/jfrog-jcenter-bintray-closure/ and I can't run the project because of this
My issue: saltstack/salt#60265
Related PR: saltstack-formulas#290
We need to merge the latest changes in order to get the binaries from Github instead of Bintray.