make gpgsql-password optional #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure about this PR. I'm leaning towards forcing database passwords as it is more secure. I also understand that flexibility is really useful too. I'd probably introduce a new variable myself which specifically disables the need for it. This would make it really explicit. |
bastelfreak
force-pushed
the
password
branch
3 times, most recently
from
49f6029 to
b53d3cd
Compare
|
@ju5t can you take a look again? |
|
👍 Would you mind adding it to the MySQL backend too? It's not required there either. And some tests to cover it perhaps? |
bastelfreak
force-pushed
the
password
branch
5 times, most recently
from
de6e750 to
874796d
Compare
At least for postgresql it's not required that the database_user has a password.
bastelfreak
force-pushed
the
password
branch
from
874796d to
a4c3742
Compare
|
hi @ju5t , let me know if you're happy with this or want more/other tests. |
|
@ju5t can you please take a look again? |
|
Sorry for the delay. Looks good to me thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least for postgresql it's not required that the database_user has a password.