Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite plugin checks to use ridley #25

Closed
2 tasks done
majormoses opened this issue Apr 26, 2017 · 2 comments
Closed
2 tasks done

rewrite plugin checks to use ridley #25

majormoses opened this issue Apr 26, 2017 · 2 comments

Comments

@majormoses
Copy link
Member

majormoses commented Apr 26, 2017

In order to support chef 13 we need to switch out chef/rest with ridley as it was removed (currently just deprecation warnings). An alternative is chefapi but this is not stable yet.

  • check-chef-node.rb
  • check-chef-nodes.rb
@majormoses
Copy link
Member Author

I do think that we should move the client connection logic into a library module as it is the same in the 2 checks above as it would be in the handler which already uses ridley.

@majormoses
Copy link
Member Author

Closing this out for the moment. would love to move all the connection logic into a lib but I just don't see me having the bandwidth as I want to start going around to all the plugins and start adding ruby 2.4 support which will be time consuming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant