rewrite chef checks to use Ridley instead of deprecated chef rest api. #26

annshah · 2017-05-08T18:33:00Z

Pull Request Checklist

Is this in reference to an existing issue?
rewrite plugin checks to use ridley issue #25

General

Update Changelog following the conventions laid out on Keep A Changelog
Update README with any necessary configuration snippets
Binstubs are created if needed
RuboCop passes
Existing tests pass

Purpose

Known Compatablity Issues

…n ignoring ssl

majormoses · 2017-05-08T19:14:43Z

bin/check-chef-node.rb

@@ -65,12 +70,16 @@ def run
    critical "Node #{config[:node_name]} not found - #{e.message}"
  end

-  private
+  private 


was there a reason for this whitespace?

majormoses · 2017-05-08T19:18:46Z

@annshah thanks for the contribution overall this looks good, if you can kill that extra whitespace and fix the gem dependency issues after some quick verification tests I would love to get this merged.

majormoses · 2017-05-08T19:22:48Z

bin/check-chef-node.rb

@@ -50,13 +50,18 @@ class ChefNodeChecker < Sensu::Plugin::Check::CLI
         short: '-K CLIENT-KEY',
         long: '--keys CLIENT-KEY'

+  option :ignore_ssl_warnings,


I think this would be more appropriately named ignore_ssl_verification

majormoses · 2017-05-08T19:23:08Z

bin/check-chef-nodes.rb

@@ -68,19 +68,24 @@ class ChefNodesStatusChecker < Sensu::Plugin::Check::CLI
         long: '--exclude-nodes EXCLUDE-NODES',
         default: '^$'

+  option :ignore_ssl_warnings,


I think this would be more appropriately named ignore_ssl_verification

majormoses · 2017-05-08T19:26:49Z

sensu-plugins-chef.gemspec

@@ -40,7 +40,7 @@ Gem::Specification.new do |s|
    s.add_runtime_dependency 'rack', '~> 1.6.5'
  end

-  s.add_runtime_dependency 'ridley',       '4.1.2'
+  s.add_runtime_dependency 'ridley',       '5.1.0'
  s.add_runtime_dependency 'sensu-plugin', '~> 1.2'
  s.add_runtime_dependency 'varia_model', '0.4.1'


looks like this needs to be bumped per travis: https://travis-ci.org/sensu-plugins/sensu-plugins-chef/jobs/230068843

…space, changed varia_model to 0.6

majormoses · 2017-05-08T20:10:29Z

I see the issue, basically ridley 5.x requires buff-extension 2.x which requires >= ruby 2.2.

@eheydrick did sensu ever ship with ruby 2.1? In this case I think we should consider dropping support and do a major bump as this solves issues for lots of users of this gem and with a rewrite I would hate to force using an old version of ridley that we are gonna have to update agains shortly anyways. Thoughts?

annshah · 2017-05-08T20:24:31Z

I was facing compatibility issues with earlier versions of ridley. So I believe using latest version might be a necessity.

majormoses · 2017-05-08T23:06:43Z

Ya I looked at it and im favor of this breaking change but would like to hear from another maintainer before merging and releasing this one.

majormoses · 2017-05-09T01:25:27Z

@cwjohnston thoughts?

cwjohnston · 2017-05-09T14:55:29Z

@majormoses per sensu-build commit history I don't think we've shipped a Sensu release with Ruby 2.1.

I find these changes agreeable for the most part. I also like the idea of implementing a module library like you mentioned in #25 (comment). Would that be reasonable here to dry things up and make it easier to move to https://github.com/sethvargo/chef-api when that becomes a stable option?

majormoses · 2017-05-09T15:02:17Z

@cwjohnston awesome thats what I was looking for! While I would like to force the connection information out right now to me the priority is to get this fixed and nice cleanup later. We should keep the original issue open to track that but I really want this merged asap.

cwjohnston · 2017-05-09T15:05:24Z

@majormoses @annshah let's remove ruby 2.1 and add ruby 2.4 to the travis matrix, if those tests pass we can shipit

edit: with a major version bump 👍

majormoses · 2017-05-09T15:09:18Z

@annshah I see you did not give maintainers access to your fork can you please add this:

$ git diff origin/master 
diff --git a/.travis.yml b/.travis.yml
index cf6c5ac..fa96a2a 100644
--- a/.travis.yml
+++ b/.travis.yml

@@ -5,7 +5,6 @@ install:
 - gem install bundler -v 1.12
 - bundle install
 rvm:
-- 2.1
 - 2.2
 - 2.3.0
 notifications:
diff --git a/CHANGELOG.md b/CHANGELOG.md
index d6a3a86..39b5372 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 This CHANGELOG follows the format listed at [Keep A Changelog](http://keepachangelog.com/)
 
 ## [Unreleased]
+### Breaking Change
+- re-wrote all checks to use latest ridley. As ridley 5.x requires buff-extension 2.x which requires >= ruby 2.2 and sensu has never shipped with ruby 2.1 the decision was made to drop this support. If you are not using an embedded ruby and are using 2.1 this will break for you. To avoid this you can either switch to embedded ruby or upgrade your ruby to at least 2.2
 
 ## [2.0.1] - 2017-04-28
 ### Fixed

Also add 2.4 as requested by @cwjohnston

- removed ruby 2.1 support - documented breaking change, impact, and upgrade path that this breaks their setup. - added ruby 2.4 testing

…into ridley

annshah · 2017-05-09T16:42:06Z

@majormoses : I have added all maintainers and Ruby 2.4.1.

majormoses · 2017-05-09T17:57:07Z

@annshah thanks I will squash and merge this

annshah added 2 commits May 8, 2017 12:23

changed files for chef library to ridley and added command line optio…

1af3ec0

…n ignoring ssl

removed comment error

86e29bd

majormoses reviewed May 8, 2017

View reviewed changes

majormoses changed the title ~~Ridley~~ rewrite check checks to use Ridley instead of deprecated chef server api. May 8, 2017

majormoses changed the title ~~rewrite check checks to use Ridley instead of deprecated chef server api.~~ rewrite chef checks to use Ridley instead of deprecated chef server api. May 8, 2017

majormoses changed the title ~~rewrite chef checks to use Ridley instead of deprecated chef server api.~~ rewrite chef checks to use Ridley instead of deprecated chef rest api. May 8, 2017

majormoses reviewed May 8, 2017

View reviewed changes

Renamed ignore_ssl_warnings to ignore_ssl_verification, removed white…

bf3c069

…space, changed varia_model to 0.6

majormoses and others added 4 commits May 9, 2017 09:14

removed travis testing for ruby 2.1 and added CHANGELOG entry:

cc11526

- removed ruby 2.1 support - documented breaking change, impact, and upgrade path that this breaks their setup. - added ruby 2.4 testing

removed ruby 2.1 from .travis.yml and updated CHANGELOG.md

756a37c

Merge branch 'ridley' of https://github.com/annshah/sensu-plugins-chef …

0309e45

…into ridley

add ruby 2.4.1

833a84e

majormoses merged commit 846cc66 into sensu-plugins:master May 9, 2017

majormoses mentioned this pull request Dec 15, 2018

Remove chef dependency that is unused #48

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rewrite chef checks to use Ridley instead of deprecated chef rest api. #26

rewrite chef checks to use Ridley instead of deprecated chef rest api. #26

annshah commented May 8, 2017 •

edited by majormoses

Loading

majormoses May 8, 2017

majormoses commented May 8, 2017

majormoses May 8, 2017

majormoses May 8, 2017

majormoses May 8, 2017

majormoses commented May 8, 2017

annshah commented May 8, 2017

majormoses commented May 8, 2017

majormoses commented May 9, 2017

cwjohnston commented May 9, 2017

majormoses commented May 9, 2017

cwjohnston commented May 9, 2017 •

edited

Loading

majormoses commented May 9, 2017 •

edited

Loading

annshah commented May 9, 2017

majormoses commented May 9, 2017

rewrite chef checks to use Ridley instead of deprecated chef rest api. #26

rewrite chef checks to use Ridley instead of deprecated chef rest api. #26

Conversation

annshah commented May 8, 2017 • edited by majormoses Loading

Pull Request Checklist

General

Purpose

Known Compatablity Issues

majormoses May 8, 2017

Choose a reason for hiding this comment

majormoses commented May 8, 2017

majormoses May 8, 2017

Choose a reason for hiding this comment

majormoses May 8, 2017

Choose a reason for hiding this comment

majormoses May 8, 2017

Choose a reason for hiding this comment

majormoses commented May 8, 2017

annshah commented May 8, 2017

majormoses commented May 8, 2017

majormoses commented May 9, 2017

cwjohnston commented May 9, 2017

majormoses commented May 9, 2017

cwjohnston commented May 9, 2017 • edited Loading

majormoses commented May 9, 2017 • edited Loading

annshah commented May 9, 2017

majormoses commented May 9, 2017

annshah commented May 8, 2017 •

edited by majormoses

Loading

cwjohnston commented May 9, 2017 •

edited

Loading

majormoses commented May 9, 2017 •

edited

Loading