Drop Ruby 1.9.3 support, add Ruby 2.3.0 & 2.4.1 testing #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majormoses
reviewed
Jul 15, 2017
| @@ -17,7 +18,7 @@ notifications: | |||
| script: | |||
| - bundle exec rake default | |||
| - gem build sensu-plugins-google-spreadsheet.gemspec | |||
| - gem install sensu-plugins-google-spreadsheet-*.gem | |||
| - gem install sensu-plugins-google-spreadsheets-*.gem | |||
There was a problem hiding this comment.
I see: https://github.com/sensu-plugins/sensu-plugins-google-spreadsheet/blob/master/sensu-plugins-google-spreadsheet.gemspec#L29 I am gonna open an issue and see if we want to either rename the gem or the repo, I think its super confusing when these are not the same...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
sensu-plugins/community#27
General
Update Changelog following the conventions laid out on Keep A Changelog
RuboCop passes
Existing tests pass
Purpose
Known Compatablity Issues